Martin Pitt
2018-10-01 08:01:23 UTC
Hello all,
For cockpit's master branch I just refined the branch protection rules to
enable this:
Dismiss stale pull request approvals when new commits are pushed
New reviewable commits pushed to a matching branch will dismiss pull request review approvals.
This is something which we already agreed to follow, and this should formalize
it and automatically remove approvals on force pushes.
Please speak up if this causes any trouble.
For cockpit-{podman,ostree} I restricted the rules even more to *require* green
tests for landing, and completely disallow direct pushes to master. In
cockpit.git we aren't quite there yet, though.
Thanks,
Martin
_______________________________________________
cockpit-devel mailing list -- cockpit-***@lists.fedorahosted.org
To unsubscribe send an email to cockpit-devel-***@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedorahosted.org/archives/list/cockpit-dev
For cockpit's master branch I just refined the branch protection rules to
enable this:
Dismiss stale pull request approvals when new commits are pushed
New reviewable commits pushed to a matching branch will dismiss pull request review approvals.
This is something which we already agreed to follow, and this should formalize
it and automatically remove approvals on force pushes.
Please speak up if this causes any trouble.
For cockpit-{podman,ostree} I restricted the rules even more to *require* green
tests for landing, and completely disallow direct pushes to master. In
cockpit.git we aren't quite there yet, though.
Thanks,
Martin
_______________________________________________
cockpit-devel mailing list -- cockpit-***@lists.fedorahosted.org
To unsubscribe send an email to cockpit-devel-***@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedorahosted.org/archives/list/cockpit-dev